error text format

Karl-Heinz · Post by **Karl-Heinz** » Fri Apr 19, 2019 10:14 am

Hi Chris

no show-stopper, but when a error is thrown its annoying that the MsgBox content is not formatted. To overcome the issue i simply added horizontal tabs to the Error:Tostring() method.

e.g.

...
sb:AppendLine( e"Descriptiont: " + SELF:Description)
sb:AppendLine( e"SubSystemt: " + SELF:SubSystem )
sb:AppendLine( e"GenCodett: " + nGenCode:ToString() )
sb:AppendLine( e"GenCodeTextt: " + SELF:GenCodeText )

...

What do you think ?

attached you find a viaef that shows the default and the modified Tostring() behaviour.

regards
Karl-Heinz

Chris · Post by **Chris** » Fri Apr 19, 2019 11:59 am

Hi Karl-Heinz,

Thanks, I agree it is better this way (provided the tabs do not get disturbed when people use different system font sizes!), but I would prefer to put the ":" just after the captions, not tabbed with the values as well, do you agree?

What everybody else thinks? Those are the 3 options, first one is the current one:

FFF · Post by **FFF** » Fri Apr 19, 2019 1:34 pm

I like #3, but shrink the tab width to the possible minimum...Or, add a dotted line between to lead the eye from key to value. Eyes and brain are getting older

wriedmann · Post by **wriedmann** » Fri Apr 19, 2019 1:48 pm

Hi Chris,

I would vote for #3.

Wolfgang

lumberjack · Post by **lumberjack** » Fri Apr 19, 2019 1:57 pm

Karl-Heinz · Post by **Karl-Heinz** » Fri Apr 19, 2019 2:07 pm

Hi Chris,

#3 is the best

regards
Karl-Heinz

Chris · Post by **Chris** » Fri Apr 19, 2019 2:22 pm

#3 it is then, thanks to all for your input!

Unfortunately printing Error:ToString() to the console does not look as nice (extra tabs are shown as extra tabs...), but I think it's still better than before.

robert · Post by **robert** » Fri Apr 19, 2019 5:22 pm

Karl-Heinz,

The fact that you are now reporting that the format of the error message is incorrect means to me that have indeed reached a mature product!

Robert

Karl-Heinz · Post by **Karl-Heinz** » Fri Apr 19, 2019 7:56 pm

robert wrote:Karl-Heinz,

The fact that you are now reporting that the format of the error message is incorrect means to me that have indeed reached a mature product!

Robert

Hi Robert,

yes, with every new build it's getting harder and harder to find bugs - at least in the areas I'm investigating

Seriously: There are problems with some round() results, but i´ll open a new thread on that.

regards
Karl-Heinz

Karl-Heinz · Post by **Karl-Heinz** » Wed Jul 03, 2019 8:12 am

Chris wrote:Unfortunately printing Error:ToString() to the console does not look as nice (extra tabs are shown as extra tabs...), but I think it's still better than before.

Hi Chris,

I´m not convinced

i think the better choice is that the window view looks good. So it´s IMO better to keep the two tabs in the following lines.

Code: Select all

sb:AppendLine(e"GenCode :tt" + nGenCode:ToString()  )
sb:AppendLine(e"SubCode :tt" + SELF:SubCode:ToString() )
sb:AppendLine(e"OsCode :tt" 	+ SELF:OsCode:ToString() )
sb:AppendLine(e"FuncSym :tt" 	+ SELF:FuncSym   )
sb:AppendLine(e"Severity :tt" + sev:ToString() )
sb:AppendLine(e"CanRetry :tt"	+ SELF:CanRetry )
sb:AppendLine(e"Tries :tt" 	+ SELF:Tries:ToString()    )
sb:AppendLine(e"ArgType :tt" 	+ TypeString(SELF:ArgType    ) )
sb:AppendLine(e"ArgNum :tt" 	+ SELF:ArgNum:ToString()    )
sb:AppendLine(e"Arg :tt" 	+ SELF:Arg)
sb:AppendLine(e"Args :tt" + cArgs)

attached are two images. The first one shows how the error text is currently shown in a window with single tab stops only. The second one shows the console and window output with two tab stops where it´s neccessary.

regards
Karl-Heinz

Main menu